[PATCH] D23760: Place the lowered phi instruction(s) before the DEBUG_VALUE entry

Keith Walker via llvm-commits llvm-commits at lists.llvm.org
Sun Aug 21 07:42:33 PDT 2016


keith.walker.arm created this revision.
keith.walker.arm added reviewers: llvm-commits, dblaikie.
Herald added subscribers: nemanjai, qcolombet.

When a phi node is finally lowered to a machine instruction it is
important that the lowered "load" instruction is placed before the
associated DEBUG_VALUE entry describing the value loaded.

Renamed the existing SkipPHIsAndLabels to SkipPHIsLabelsAndDebug to
more fully describe that it also skips debug entries.  The used the
"new" function SkipPHIsAndLabels when the debug information should not
be skipped when placing the lowered "load" instructions so that it is
placed before the debug entries.



https://reviews.llvm.org/D23760

Files:
  include/llvm/CodeGen/MachineBasicBlock.h
  lib/CodeGen/InlineSpiller.cpp
  lib/CodeGen/LiveDebugVariables.cpp
  lib/CodeGen/MachineBasicBlock.cpp
  lib/CodeGen/PHIEliminationUtils.cpp
  lib/CodeGen/SplitKit.cpp
  lib/Target/PowerPC/PPCEarlyReturn.cpp
  test/CodeGen/AArch64/phi-dbg.ll

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D23760.68815.patch
Type: text/x-patch
Size: 8108 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20160821/0a11eace/attachment.bin>


More information about the llvm-commits mailing list