[PATCH] D23739: [LTO] Handles commons in monolithic LTO

[Teresa Johnson via llvm-commits]

tejohnson added a comment.

Getting a failure in your new test. I assume it wasn't designed for the case where we assume all are prevailing.

-

/usr/local/google/home/tejohnson/llvm/llvm_13/test/tools/llvm-lto2/common.ll:61:23: error: expected string not found in input
; LARGE_LITTLE_ALIGN: @v = common global [2 x i8] zeroinitializer, align 4

  ^

<stdin>:1:1: note: scanning from here
; ModuleID = '<stdin>'
^
<stdin>:5:1: note: possible intended match here
@v = common global [2 x i8] zeroinitializer, align 8
^

-


================
Comment at: lib/LTO/LTO.cpp:298
@@ +297,3 @@
+    // what is the "right" behavior here.
+    if Sym.getFlags() & object::BasicSymbolRef::SF_Common) {
+      auto &CommonRes = RegularLTO.Commons[Sym.getIRName()];
----------------
Missing opening "("


https://reviews.llvm.org/D23739