[PATCH] D23739: [LTO] Handles commons in monolithic LTO

[Mehdi AMINI via llvm-commits]

mehdi_amini added inline comments.

================
Comment at: lib/LTO/LTO.cpp:296
@@ +295,3 @@
+    // Common resolution: collect the maximum size/alignment.
+    // FIXME: right now we ignore the prevailing information, it is not clear
+    // what is the "right" behavior here.
----------------
I none is prevailing, then the linker would drop this global anyway?
Note that the global already exists in the merged module, so if we track if none is prevailing, should we remove it?


https://reviews.llvm.org/D23739