[PATCH] D23739: [LTO] Handles commons in monolithic LTO

[Teresa Johnson via llvm-commits]

tejohnson added a comment.

Still needs the unused var fixes I noted in the previous comments.


================
Comment at: lib/LTO/LTO.cpp:296
@@ +295,3 @@
+    // Common resolution: collect the maximum size/alignment.
+    // FIXME: right now we ignore the prevailing information, it is not clear
+    // what is the "right" behavior here.
----------------
I noticed that what the existing gold-plugin support does is treat either all as prevailing or none as prevailing - it tracks whether any was prevailing in the CommonResolution structure, and doesn't create a new merged common if none were. Perhaps that should be done here, but I'm not sure when the linker would decide none was prevailing?


https://reviews.llvm.org/D23739