[llvm] r279341 - GlobalISel: support legalization of G_FCONSTANTs

[Matt Arsenault via llvm-commits]

> On Aug 19, 2016, at 15:40, Tim Northover via llvm-commits <llvm-commits at lists.llvm.org> wrote:
> 
> Author: tnorthover
> Date: Fri Aug 19 17:40:08 2016
> New Revision: 279341
> 
> URL: http://llvm.org/viewvc/llvm-project?rev=279341&view=rev
> Log:
> GlobalISel: support legalization of G_FCONSTANTs
> 
> Modified:
>    llvm/trunk/include/llvm/CodeGen/GlobalISel/MachineIRBuilder.h
>    llvm/trunk/lib/CodeGen/GlobalISel/MachineIRBuilder.cpp
>    llvm/trunk/lib/CodeGen/GlobalISel/MachineLegalizeHelper.cpp
>    llvm/trunk/lib/Target/AArch64/AArch64MachineLegalizer.cpp
>    llvm/trunk/test/CodeGen/AArch64/GlobalISel/legalize-constant.mir

Why bother having a separate constant type for FP? In AMDGPU and AArch64, isel bitcasts all FP constants into integer immediates and uses the bitvalues. Is there any value into keeping fpimm around?

-Matt