[PATCH] D23725: [CallGraph] Use decltype instead of pointer_to_unary_function. NFC.

Tim Shen via llvm-commits llvm-commits at lists.llvm.org
Fri Aug 19 14:59:23 PDT 2016


timshen added inline comments.

================
Comment at: include/llvm/Analysis/CallGraph.h:440
@@ -442,2 +439,3 @@
 
-  typedef mapped_iterator<NodeType::const_iterator, CGNDerefFun>
+  static const CallGraphNode *CGNGetValue(CGNPairTy P) { return P.second; }
+
----------------
dblaikie wrote:
> Two are called CGNGetValue and two are called CGGetValuePtr - any particular reason for the variety?
CGGetValuePtr calls unique_ptr::get() - it's like get the unique_ptr value, then get the (raw) ptr from the unique_ptr.


https://reviews.llvm.org/D23725





More information about the llvm-commits mailing list