[llvm] r279278 - GlobalISel: support overflow arithmetic intrinsics.
Tim Northover via llvm-commits
llvm-commits at lists.llvm.org
Fri Aug 19 14:35:08 PDT 2016
> I haven’t commented on that on the other patches, but I would prefer we avoid the {} notation for constructor because this is not consistent with the rest of the LLVM codebase as far as I can tell. I.e., we use ().
Well, it's only been around since C++11 so you wouldn't expect it in much of the code. But I think it provides useful sanity checks over the old syntax (implicit conversions are disallowed so you won't get away with "ObjWithShortConstructor obj{MyLong}").
It's also explicitly called out as an allowed C++11 feature in our list (http://llvm.org/docs/CodingStandards.html, "Initializer Lists").
(BTW: octane.bc translates now!)
Tim.
More information about the llvm-commits
mailing list