[PATCH] D23646: Generalize strided store pattern in interleave access pass

Matthew Simpson via llvm-commits llvm-commits at lists.llvm.org
Fri Aug 19 13:35:38 PDT 2016


mssimpso added a comment.

Hi Alina,

I think I understand this, but I just want to be sure I get how this differs from what we currently have before going further. Currently, we only match [x, y, ..., z, x+1, y+1, z+1, ...] where each y-x and each z-y equals the number of sub elements for the given factor. Or said another way, if I create a list or all the x's followed by all the y's and then all the z's, the entire list would be consecutive. With your path, the only requirement is that each sub-list be consecutive. Is this right?

The current approach was designed to match the shuffle patterns produced by the loop vectorizer. I'm curious to know where we are generating these more general patterns. Have you run across some code examples?

Also, another high level comment before I start looking at the details: you'll want to include some IR test cases as well (to be run with opt instead of llc).

Matt.


https://reviews.llvm.org/D23646





More information about the llvm-commits mailing list