[PATCH] D23687: AMDGPU/SI: Use a better method for determining the largest pressure sets

[Matt Arsenault via llvm-commits]

arsenm added inline comments.

================
Comment at: lib/Target/AMDGPU/SIRegisterInfo.h:190-195
@@ -189,1 +189,8 @@
 
+  bool isSGPRPressureSet(unsigned SetID) const {
+    return SGPRPressureSets.test(SetID) && !VGPRPressureSets.test(SetID);
+  }
+  bool isVGPRPressureSet(unsigned SetID) const {
+    return VGPRPressureSets.test(SetID) && !SGPRPressureSets.test(SetID);
+  }
+
----------------
tstellarAMD wrote:
> arsenm wrote:
> > Why do these need to check that it's not in the other set? Are there still issues from VS_32 being allocatable?
> Yes, we need to make sure we ignore VS_32.
But you should never see a VS_32 virtual register. Will this be fixed when making it unallocatable? This probably needs a comment/fixme


https://reviews.llvm.org/D23687