[PATCH] D22987: [lldb][cmake] Remove libclang as an lldbBase dependency (NFCI)

Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Aug 19 11:49:55 PDT 2016


This revision was automatically updated to reflect the committed changes.
Closed by commit rL279296: [lldb][cmake] Remove libclang as an lldbBase dependency (NFCI) (authored by vedantk).

Changed prior to commit:
  https://reviews.llvm.org/D22987?vs=66584&id=68717#toc

Repository:
  rL LLVM

https://reviews.llvm.org/D22987

Files:
  lldb/trunk/CMakeLists.txt
  lldb/trunk/cmake/modules/AddLLDB.cmake

Index: lldb/trunk/cmake/modules/AddLLDB.cmake
===================================================================
--- lldb/trunk/cmake/modules/AddLLDB.cmake
+++ lldb/trunk/cmake/modules/AddLLDB.cmake
@@ -84,10 +84,7 @@
     endif()
   endif()
 
-  # Hack: only some LLDB libraries depend on the clang autogenerated headers,
-  # but it is simple enough to make all of LLDB depend on some of those
-  # headers without negatively impacting much of anything.
-  add_dependencies(${name} libclang)
+  add_dependencies(${name} ${CLANG_USED_LIBS})
 
   set_target_properties(${name} PROPERTIES FOLDER "lldb libraries")
 endmacro(add_lldb_library)
Index: lldb/trunk/CMakeLists.txt
===================================================================
--- lldb/trunk/CMakeLists.txt
+++ lldb/trunk/CMakeLists.txt
@@ -1,5 +1,6 @@
 cmake_minimum_required(VERSION 3.4.3)
 
+include(cmake/LLDBDependencies.cmake)
 include(cmake/modules/LLDBStandalone.cmake)
 include(cmake/modules/LLDBConfig.cmake)
 include(cmake/modules/AddLLDB.cmake)


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D22987.68717.patch
Type: text/x-patch
Size: 1023 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20160819/d9c030ef/attachment.bin>


More information about the llvm-commits mailing list