[PATCH] D23656: [CMake] Fix ASM building in llvm/runtimes

Jonas Hahnfeld via llvm-commits llvm-commits at lists.llvm.org
Thu Aug 18 23:11:18 PDT 2016


Hahnfeld marked an inline comment as done.

================
Comment at: CMakeLists.txt:12
@@ +11,3 @@
+# runtimes directory.
+if (CMAKE_SOURCE_DIR STREQUAL CMAKE_CURRENT_SOURCE_DIR OR
+    "${CMAKE_SOURCE_DIR}/compiler-rt" STREQUAL CMAKE_CURRENT_SOURCE_DIR)
----------------
beanz wrote:
> Actually, I do have one suggestion here. Make this:
> 
> 
> ```
> if (CMAKE_SOURCE_DIR STREQUAL CMAKE_CURRENT_SOURCE_DIR OR COMPILER_RT_STANDALONE_BUILD)
> ```
> 
> The runtimes subdirectory CMake file sets the *_STANDALONE_BUILD variable, so we can use it before it would be set in the normal standalone build.
Yes, I just saw your changes for `libcxx` and will do the change when commiting.


https://reviews.llvm.org/D23656





More information about the llvm-commits mailing list