[PATCH] D23649: [ADT] Change the range-based for loop in DFS to normal loop. NFC.
Dean Michael Berris via llvm-commits
llvm-commits at lists.llvm.org
Thu Aug 18 22:49:20 PDT 2016
dberris added a comment.
(Replying here because the comments on the mailing list don't seem to get reflected in Phab)
I think what confused me asking for a test case was that it wasn't clear from the description what exactly is being "fixed" (because of the word "correct").
I think a comment in the code would help explain why you're doing this instead of using a range-based loop, and an update to the description would be really helpful.
https://reviews.llvm.org/D23649
More information about the llvm-commits
mailing list