[PATCH] D23681: [LTO] Add the ability to test -thinlto-emit-imports-files through llvm-lto2

[Mehdi AMINI via llvm-commits]

mehdi_amini added a comment.

In https://reviews.llvm.org/D23681#519900, @tejohnson wrote:

> In https://reviews.llvm.org/D23681#519878, @mehdi_amini wrote:
>
> > In https://reviews.llvm.org/D23681#519861, @tejohnson wrote:
> >
> > > Looks like we crossed wires a bit - see my https://reviews.llvm.org/D23680 patch. We have chosen slightly different options names (I chose thinlto-index-only to be more consistent with the gold-plugin).
> >
> >
> > Interestingly I copy/pasted the option name from the gold-plugin!!
>
>
> That particular option only has an effect under thinlto-index-only, which guards the creation of the WriteIndexesThinBackend and subsequent early exit from the link. For my patch I decided in llvm-lto2 to just enable both under the single parent option, similar to how you are enabling both (writing the individual indexes and the imports files as well) with one option. I think it is better to have that one option be the thinlto-index-only since it is the main option for this path on the plugin side.


In llvm-lto there was three options: `thinlink` (write only the index), `distributedindexes` (write the individual indexes for distributed backends), and `emitimports` (write the list of imports for each module).

So how do you see the mapping? One option for all of these together? The name "thinlto-index-only" makes me think about the first one only.


https://reviews.llvm.org/D23681