[PATCH] D23663: [ELF] - Linkerscript: set correct synamic tag entries values when LS is used.

[Rui Ueyama via llvm-commits]

ruiu added inline comments.

================
Comment at: ELF/OutputSections.h:589-594
@@ -591,4 +588,8 @@
+    enum KindT { SecAddr, SecSize, SymAddr, PlainInt } Kind;
+    Entry(int32_t Tag, OutputSectionBase<ELFT> *OutSec, KindT Kind = SecAddr)
+        : Tag(Tag), OutSec(OutSec), Kind(Kind) {}
     Entry(int32_t Tag, uint64_t Val) : Tag(Tag), Val(Val), Kind(PlainInt) {}
     Entry(int32_t Tag, const SymbolBody *Sym)
         : Tag(Tag), Sym(Sym), Kind(SymAddr) {}
+    Entry(int32_t Tag) : Tag(Tag), Kind(SecSize) {}
   };
----------------
You have added three new constructors (a constructor with an optional parameter actually defines two ctors.) It's probably too much. Please remove the default argument at least.

================
Comment at: ELF/OutputSections.h:594
@@ -593,2 +593,3 @@
         : Tag(Tag), Sym(Sym), Kind(SymAddr) {}
+    Entry(int32_t Tag) : Tag(Tag), Kind(SecSize) {}
   };
----------------
Why do you need this?


https://reviews.llvm.org/D23663