[llvm] r278544 - [LibFuzzer] Fix `-jobs=<N>` where <N> > 1 and the number of workers is > 1 on macOS.

[Kostya Serebryany via llvm-commits]

On Thu, Aug 18, 2016 at 11:29 AM, Dan Liew <dan at su-root.co.uk> wrote:

> >> Perhaps the 1 second time is
> >> too short for some buildbots if they are under load? We could extend
> >> the time we wait (to something > 1 second) but we'd have to probably
> >> increase `-max_total_time=4` to something larger. This wouldn't be a
> >> real fix though as the test would still be racey.
> >
> >
> > I think it can be rewritten to be non-racey.
> > Just run it with -max_total_time=2 -jobs=2 and let it and all children
> exit
> > -- then check that the files exist and are good.
>
> I agree that doing that would be non-racey however that would be
> testing a slightly different property (that all jobs eventually run)
> rather than what the test is currently trying to check (that LibFuzzer
> can spawn multiple copies of itself running in parallel). The change
> you proposing to the test would fail to catch the problem that I fixed
> on macOS (LibFuzzer would not run multiple jobs in parallel).
>

Ok...
You can probably modify your test to do grep "Running 2 workers" instead of
sleeping...
This sucks. :(
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20160818/0a1d3c02/attachment.html>