[PATCH] D23683: Include X86CallFrameOptimization in the opt-bisect process

Andy Kaylor via llvm-commits llvm-commits at lists.llvm.org
Thu Aug 18 11:40:49 PDT 2016


andrew.w.kaylor created this revision.
andrew.w.kaylor added reviewers: mkuper, rnk.
andrew.w.kaylor added a subscriber: llvm-commits.
andrew.w.kaylor set the repository for this revision to rL LLVM.

This patch updates the X86CallFrameOptimization in such a way that it can be skipped when using the -opt-bisect-limit option.

This pass was not included when I originally implemented this feature in the x86-specific passes (see D19439) because at that time it was being run at -O0.  Since D22362 introduced a check to omit this pass at -O0 it can now also be included in the opt-bisect process.

The change I am making here will also cause this pass to be skipped for any function that has the opt-none function attribute.

Repository:
  rL LLVM

https://reviews.llvm.org/D23683

Files:
  lib/Target/X86/X86CallFrameOptimization.cpp

Index: lib/Target/X86/X86CallFrameOptimization.cpp
===================================================================
--- lib/Target/X86/X86CallFrameOptimization.cpp
+++ lib/Target/X86/X86CallFrameOptimization.cpp
@@ -225,7 +225,7 @@
   assert(isPowerOf2_32(SlotSize) && "Expect power of 2 stack slot size");
   Log2SlotSize = Log2_32(SlotSize);
 
-  if (!isLegal(MF))
+  if (skipFunction(*MF.getFunction()) || !isLegal(MF))
     return false;
 
   unsigned FrameSetupOpcode = TII->getCallFrameSetupOpcode();


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D23683.68581.patch
Type: text/x-patch
Size: 510 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20160818/efed3cc0/attachment.bin>


More information about the llvm-commits mailing list