[PATCH] D23681: [LTO] Add the ability to test -thinlto-emit-imports-files through llvm-lto2

[Mehdi AMINI via llvm-commits]

mehdi_amini added a comment.

In https://reviews.llvm.org/D23681#519861, @tejohnson wrote:

> Looks like we crossed wires a bit - see my https://reviews.llvm.org/D23680 patch. We have chosen slightly different options names (I chose thinlto-index-only to be more consistent with the gold-plugin).


Interestingly I copy/pasted the option name from the gold-plugin!!

> I added a similar llvm-lto2 based test to an existing llvm-lto based test.


I plan to kill the support for this option in llvm-lto in a subsequent patch, in which I'll convert the existing llvm-lto test to llvm-lto2, that's the main reason I submitted a new test here (I extracted this change from the other patch, and figured I'd submit a test for this patch and wrote one), but I'm fine just using the other test as well instead.

> Do you have a preference on which version of the llvm-lto support and test to take? Since you have also added the Threads option maybe we should use yours (but I think I like thinlto-index-only better for the option), and I can rebase on top. WDYT?


I don't have a strong preference, but I'd add the llvm-lto2 support separately.


https://reviews.llvm.org/D23681