[llvm] r278544 - [LibFuzzer] Fix `-jobs=<N>` where <N> > 1 and the number of workers is > 1 on macOS.

Kostya Serebryany via llvm-commits llvm-commits at lists.llvm.org
Thu Aug 18 10:42:11 PDT 2016


On Thu, Aug 18, 2016 at 10:31 AM, Dan Liew <dan at su-root.co.uk> wrote:

> Hi Kostya,
>
> On 17 August 2016 at 01:44, Kostya Serebryany <kcc at google.com> wrote:
> > fuzzer-jobs.test periodically fails.
> > Do you see that?
>
> Sorry for the delay in responding. I've been travelling back home.
>
> I've not been getting any buildbot failure notifications about this.
>
> The test I've written is racey though. It will fail if LibFuzzer
> hasn't managed to spawn two LibFuzzer child processes that have
> created their log files within 1 second.


I usually see it on a local machine when it's busy doing other stuff.



> Perhaps the 1 second time is
> too short for some buildbots if they are under load? We could extend
> the time we wait (to something > 1 second) but we'd have to probably
> increase `-max_total_time=4` to something larger. This wouldn't be a
> real fix though as the test would still be racey.
>

I think it can be rewritten to be non-racey.
Just run it with -max_total_time=2 -jobs=2 and let it and all children exit
-- then check that the files exist and are good.


>
> Dan.
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20160818/245f3627/attachment.html>


More information about the llvm-commits mailing list