[PATCH] D23583: [AArch64] Add feature has-fast-fma

[Evandro Menezes via llvm-commits]

evandro added a comment.

In https://reviews.llvm.org/D23583#518754, @rengolin wrote:

> In https://reviews.llvm.org/D23583#518683, @MatzeB wrote:
>
> > From a design point of view I agree. TargetInstrInfo callbacks appear to mix ISA specifics with cost model/tuning options and it would be cleaner to have the tuning/cost model stuff part of the scheduling Model (or create a new interface called TargetTuning or TargetCostModel).
> >  But we have to discuss this outside of this patch I believe.
>
>
> Should be ok to have the target feature with a FIXME to move it to cost model, and drive the discussion on the list in the meantime.


I agree.  At the moment, I am not sure all the traits of all the targets which should be considered in devising the heuristics for such generalization.  Yet, it should be a very interesting discussion which I'd love to take part in.


Repository:
  rL LLVM

https://reviews.llvm.org/D23583