[PATCH] D23625: [Analysis] Change several Analysis pieces to use NodeRef. NFC.

[Tobias Grosser via llvm-commits]

grosser added a comment.

Hi Tim,

thank you for looking through this. The general direction and the changes look fine for RegionInfo. I let David finish his detailed comments (thank you David!) for him to give the final OK.


================
Comment at: include/llvm/Analysis/RegionIterator.h:58
@@ -52,3 +57,3 @@
   // Use two bit to represent the mode iterator.
-  PointerIntPair<NodeType*, 2, ItMode> Node;
+  PointerIntPair<NodeRef, 2, ItMode> Node;
 
----------------
This seems a good solution for now. This PointerIntPair should just be replaced with two separate fields, but can be done later on. However, this will not be sufficient to allow pointer types, as there seem to be other uses of PtrSet, which would need to be changed. I assume we leave this for when there is an actual need for a non-pointer type.


https://reviews.llvm.org/D23625