[PATCH] D23623: [asan] Add support of lifetime poisoning into ComputeASanStackFrameLayout

Evgeniy Stepanov via llvm-commits llvm-commits at lists.llvm.org
Wed Aug 17 18:01:56 PDT 2016


eugenis added inline comments.

================
Comment at: lib/Transforms/Utils/ASanStackFrameLayout.cpp:84
@@ -83,2 +83,3 @@
     assert(Size > 0);
+    assert(Vars[i].LifetimeSize <= Size);
     StackDescription << " " << Offset << " " << Size << " " << strlen(Name)
----------------
eugenis wrote:
> You need a stronger assert: lifetime aligned up is not larger than size. Right?
OK, this assert is fine.



https://reviews.llvm.org/D23623





More information about the llvm-commits mailing list