[PATCH] D23632: [LTO] Promote before performing weak resolution

Mehdi AMINI via llvm-commits llvm-commits at lists.llvm.org
Wed Aug 17 17:32:10 PDT 2016


mehdi_amini added inline comments.

================
Comment at: test/ThinLTO/X86/internalize.ll:10
@@ +9,3 @@
+; RUN:     -r=%t1.bc,_linkonce_func,pl
+; RUN: llvm-dis < %t.o.0.2.internalized.bc | FileCheck  %s --check-prefix=INTERNALIZE
+
----------------
tejohnson wrote:
> It passes only if I change the file name to "%t.o.1.2.internalize.bc"
> 
> Note there are two changes in the name: s/0/1/ and s/internalized/internalize/.
Yes, annoyingly the suffix for the temporary names for the new API don't match the ThinLTOCodeGenerator ones. I had a local patch to correct this while I'm migrating.


https://reviews.llvm.org/D23632





More information about the llvm-commits mailing list