[PATCH] D21189: Create subranges for new intervals resulting from live interval splitting

Quentin Colombet via llvm-commits llvm-commits at lists.llvm.org
Wed Aug 17 16:12:52 PDT 2016


> On Aug 17, 2016, at 10:52 AM, Krzysztof Parzyszek <kparzysz at codeaurora.org> wrote:
> 
> kparzysz added a comment.
> 
> In https://reviews.llvm.org/D21189#514512, @MatzeB wrote:
> 
>> This should have simpler tests that make the problem obvious. I am currently experimenting with this (still needs some CHECK lines though
> 
> 
> This test crashes without the patch and compiles cleanly with it.  Was that the intent?  If so, why would it need CHECK lines, isn't the "REQUIRES: asserts" sufficient?

For testing, it is better to check that we generate something sane, not just that we do not crash. The requires asserts is usually used when check lines depend on debug output like the vectorizer cost model.

Q.

> 
> 
> Repository:
>  rL LLVM
> 
> https://reviews.llvm.org/D21189
> 
> 
> 



More information about the llvm-commits mailing list