[PATCH] D23583: [AArch64] Add feature has-fast-fma

Renato Golin via llvm-commits llvm-commits at lists.llvm.org
Wed Aug 17 15:44:37 PDT 2016


rengolin added a comment.

In https://reviews.llvm.org/D23583#518683, @MatzeB wrote:

> From a design point of view I agree. TargetInstrInfo callbacks appear to mix ISA specifics with cost model/tuning options and it would be cleaner to have the tuning/cost model stuff part of the scheduling Model (or create a new interface called TargetTuning or TargetCostModel).
>  But we have to discuss this outside of this patch I believe.


Should be ok to have the target feature with a FIXME to move it to cost model, and drive the discussion on the list in the meantime.

cheers,
--renato


Repository:
  rL LLVM

https://reviews.llvm.org/D23583





More information about the llvm-commits mailing list