[PATCH] D23612: [LTO] Change addSaveTemps API: do not add dot to the supplied prefix path

Teresa Johnson via llvm-commits llvm-commits at lists.llvm.org
Wed Aug 17 14:41:33 PDT 2016


tejohnson added inline comments.

================
Comment at: lib/LTO/LTOBackend.cpp:64
@@ -65,3 +63,3 @@
         PathPrefix = M.getModuleIdentifier();
-      std::string Path = PathPrefix + "." + PathSuffix + ".bc";
+      std::string Path = PathPrefix + PathSuffix + ".bc";
       std::error_code EC;
----------------
With this change we won't get the "." between the module ID and the suffix in the case when we have set UseInputModulePath to true. I suspect that will cause gold tests to fail (and is less pretty overall).

Instead, can the new addition of "." after the Task Id on line 61 be removed?


https://reviews.llvm.org/D23612





More information about the llvm-commits mailing list