[llvm] r278970 - Replace a few more "fall through" comments with LLVM_FALLTHROUGH

Kostya Serebryany via llvm-commits llvm-commits at lists.llvm.org
Wed Aug 17 14:39:59 PDT 2016


FYI: this broke libFuzzer.
libFuzzer does not (and should not) include any of the LLVM headers, and
so LLVM_FALLTHROUGH is not defined.
fixed in 278982

--kcc

On Wed, Aug 17, 2016 at 1:30 PM, Justin Bogner via llvm-commits <
llvm-commits at lists.llvm.org> wrote:

> Author: bogner
> Date: Wed Aug 17 15:30:52 2016
> New Revision: 278970
>
> URL: http://llvm.org/viewvc/llvm-project?rev=278970&view=rev
> Log:
> Replace a few more "fall through" comments with LLVM_FALLTHROUGH
>
> Follow up to r278902. I had missed "fall through", with a space.
>
>
> Modified: llvm/trunk/lib/Fuzzer/FuzzerMutate.cpp
> URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/Fuzzer/
> FuzzerMutate.cpp?rev=278970&r1=278969&r2=278970&view=diff
> ============================================================
> ==================
> --- llvm/trunk/lib/Fuzzer/FuzzerMutate.cpp (original)
> +++ llvm/trunk/lib/Fuzzer/FuzzerMutate.cpp Wed Aug 17 15:30:52 2016
> @@ -286,7 +286,7 @@ size_t MutationDispatcher::Mutate_CrossO
>        NewSize = InsertPartOf(O.data(), O.size(), U.data(), U.size(),
> MaxSize);
>        if (NewSize)
>          break;
> -      // Fallthrough
> +      LLVM_FALLTHROUGH;
>      case 2:
>        NewSize = CopyPartOf(O.data(), O.size(), U.data(), U.size());
>        break;
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20160817/32e45495/attachment.html>


More information about the llvm-commits mailing list