[PATCH] D23552: [ELF] - Give automatically generated __start_* and __stop_* symbols default visibility.

Rui Ueyama via llvm-commits llvm-commits at lists.llvm.org
Wed Aug 17 13:03:09 PDT 2016


ruiu added inline comments.

================
Comment at: ELF/SymbolTable.cpp:425
@@ -424,3 +424,3 @@
   std::tie(S, WasInserted) =
-      insert(N, STT_NOTYPE, STV_HIDDEN, /*CanOmitFromDynSym*/ false,
+      insert(N, STT_NOTYPE, StOther & 3, /*CanOmitFromDynSym*/ false,
              /*IsUsedInRegularObj*/ true, nullptr);
----------------
I'm not the type of person who wants to eliminate all constants, but 3? It's too magical.


https://reviews.llvm.org/D23552





More information about the llvm-commits mailing list