[PATCH] D23063: [ELF] - Linkerscript: implemented SUBALIGN() command.

[Rui Ueyama via llvm-commits]

ruiu added inline comments.

================
Comment at: ELF/LinkerScript.cpp:289
@@ -287,1 +288,3 @@
+        if (Cmd->SubalignExpr)
+          Sec->Alignment = Cmd->SubalignExpr(0);
         OutSec->addSection(Sec);
----------------
Do not call SubalignExpr in this loop because it's a constant value.

================
Comment at: ELF/LinkerScript.cpp:630
@@ -625,2 +629,3 @@
   Expr readAlign();
+  Expr readSubAlign();
   void readSort();
----------------
SubAlign -> Subalign.

================
Comment at: ELF/LinkerScript.cpp:915
@@ -909,1 +914,3 @@
 
+Expr ScriptParser::readSubAlign() {
+  expect("(");
----------------
Use `readParenExpr`.


https://reviews.llvm.org/D23063