[PATCH] D23580: [GraphWriter] Change GraphWriter to use NodeRef in GraphTraits

David Blaikie via llvm-commits llvm-commits at lists.llvm.org
Wed Aug 17 11:03:36 PDT 2016


dblaikie accepted this revision.
dblaikie added a comment.
This revision is now accepted and ready to land.

Thanks for the explanation - I think that makes sense, that node printability is an orthogonal concept from the graph traits, hopefully. (the counterexample to this would be if two graphs have the same noderef type but need different printing schemes, but I thin kthat'd only come up if there was a concept of a "graph" distinct from nodes in the graph traits machinery (ie: if you didn't need fat pointers because you already had access to the graph... anyway))


https://reviews.llvm.org/D23580





More information about the llvm-commits mailing list