[PATCH] D23367: [SystemZ] Use valid base/index registers for memory constraints

Ulrich Weigand via llvm-commits llvm-commits at lists.llvm.org
Wed Aug 17 10:21:35 PDT 2016


uweigand accepted this revision.
uweigand added a comment.
This revision is now accepted and ready to land.

In https://reviews.llvm.org/D23367#518229, @zhanjunl wrote:

> My thinking is that if there's a hard coded register, then we should let it go through, flaws and all. So for the example of a user hard coding the register, we should be doing exactly what the user wants. If the user specifies r0 as the base/index register, then r0 should be what we use for that register, even if it's wrong. LLVM will throw an error when it detects that anyway.


OK, fair enough.  Patch LGTM, thanks!


https://reviews.llvm.org/D23367





More information about the llvm-commits mailing list