[PATCH] D23570: Fix SystemZ compilation abort caused by negative AND mask

Ulrich Weigand via llvm-commits llvm-commits at lists.llvm.org
Wed Aug 17 08:20:36 PDT 2016


uweigand added a comment.

I agree it makes sense to do this transformation in PerformDAGCombine.  Patch looks good to me.

However, once we do this here, aren't the peepholes in SystemZInstrInfo.td now superfluous?  If so, they should be removed again ...

Also, please update the comment before combineSHIFTROT so it matches the new behaviour of the routine.


https://reviews.llvm.org/D23570





More information about the llvm-commits mailing list