[PATCH] D23516: [ARM] Generate consistent frame records for Thumb2

Oliver Stannard via llvm-commits llvm-commits at lists.llvm.org
Wed Aug 17 06:54:05 PDT 2016


olista01 added a comment.

I can remove the iOS || WatchOS check in ARMFrameLowering::hasFP (and add the "no-frame-pointer-elim" attribute to all the iOS/WatchOS tests).

However, what about the  checks that enable the split push/pop, in ARMSubtarget::splitFramePushPop and ARMBaseRegisterInfo::getCalleeSavedRegs? These currently check a mixture of isMachO and isDarwin, but the comments and name of the callee-saved reg list mention iOS. Which of these is correct?


Repository:
  rL LLVM

https://reviews.llvm.org/D23516





More information about the llvm-commits mailing list