[PATCH] D23036: [SelectionDAG] Use a union of bitfield structs for SDNode::SubclassData.

[Justin Lebar via llvm-commits]

jlebar marked 4 inline comments as done.

================
Comment at: llvm/include/llvm/CodeGen/SelectionDAGNodes.h:415
@@ +414,3 @@
+    // accessors above.
+    uint16_t _HasDebugValue : 1;
+    uint16_t _IsMemIntrinsic : 1;
----------------
chandlerc wrote:
> using an explicitly *sized* type for a bitfield seems... actively confusing. I'd just use 'unsigned'.
They pack differently?  https://godbolt.org/g/dwzPfq

We're trying to pack these with an int16_t (SDNode::NodeType).


https://reviews.llvm.org/D23036