[PATCH] D23597: [SelectionDAG] Make the world a less confusing place by renaming frnd -> fround and fround -> fpround

[Michael Kuperstein via llvm-commits]

mkuper created this revision.
mkuper added reviewers: jlebar, hfinkel.
mkuper added a subscriber: llvm-commits.
Herald added a reviewer: tstellarAMD.
Herald added subscribers: nemanjai, jyknight, arsenm, jfb, jholewinski.

This way, the names of the tablegen defs match the names of the associated ISD nodes.

Hal, I saw you named frnd this way intentionally, because fround was already taken. Do you think renaming fround to fpround will cause more trouble than it's worth?
This will break out-of-tree backends, but it should not break them silently - the type constraints on the old fround and new fround are different, so patterns using the old fround will not compile with the new one.

Note that the confusion is not theoretical. :-) jlebar and I spent some time staring at a broken pattern until we had the "oh, this should be an *frnd*" realization.

https://reviews.llvm.org/D23597

Files:
  include/llvm/Target/TargetSelectionDAG.td
  lib/Target/AArch64/AArch64InstrFormats.td
  lib/Target/AArch64/AArch64InstrInfo.td
  lib/Target/AMDGPU/SIInstructions.td
  lib/Target/ARM/ARMInstrVFP.td
  lib/Target/Hexagon/HexagonISelLowering.cpp
  lib/Target/Hexagon/HexagonInstrInfoV5.td
  lib/Target/Mips/MipsInstrFPU.td
  lib/Target/NVPTX/NVPTXISelLowering.cpp
  lib/Target/NVPTX/NVPTXInstrInfo.td
  lib/Target/PowerPC/PPCInstrInfo.td
  lib/Target/PowerPC/PPCInstrQPX.td
  lib/Target/PowerPC/PPCInstrVSX.td
  lib/Target/Sparc/SparcISelLowering.cpp
  lib/Target/Sparc/SparcInstrInfo.td
  lib/Target/SystemZ/SystemZISelLowering.cpp
  lib/Target/SystemZ/SystemZInstrFP.td
  lib/Target/SystemZ/SystemZInstrVector.td
  lib/Target/WebAssembly/WebAssemblyInstrConv.td
  lib/Target/X86/X86InstrAVX512.td
  lib/Target/X86/X86InstrFPStack.td
  lib/Target/X86/X86InstrSSE.td

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D23597.68296.patch
Type: text/x-patch
Size: 36773 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20160817/a2063c7c/attachment.bin>