[PATCH] D23486: [llvm-cov] Add coverage summary information to the HTML index page.

[Vedant Kumar via llvm-commits]

vsk added inline comments.

================
Comment at: SourceCoverageView.h:145
@@ -144,3 +144,3 @@
   /// \brief Create an index which lists reports for the given source files.
-  virtual Error createIndexFile(ArrayRef<StringRef> SourceFiles) = 0;
+  virtual Error createIndexFile(const coverage::CoverageMapping &Coverage) = 0;
 
----------------
The set of SourceFiles being passed to createIndexFile may not be the same as the Coverage.getUniqueSourceFiles(). Please keep the SourceFiles argument.

================
Comment at: SourceCoverageViewHTML.cpp:268
@@ -243,3 +267,3 @@
     std::string ViewPath = getOutputPath(Path, "html", InToplevel);
-    emitPrelude(*OS.get(), Opts, getPathToStyle(ViewPath));
+    emitPrelude(*OS.get(), getCSSForCoverage(Opts, getPathToStyle(ViewPath)));
   }
----------------
Looks good.

================
Comment at: SourceCoverageViewText.cpp:92
@@ -90,4 +91,3 @@
 void SourceCoverageViewText::renderLine(
-    raw_ostream &OS, LineRef L,
-    const coverage::CoverageSegment *WrappedSegment,
+    raw_ostream &OS, LineRef L, const coverage::CoverageSegment *WrappedSegment,
     CoverageSegmentArray Segments, unsigned ExpansionCol, unsigned ViewDepth) {
----------------
Ditto -- formatting-only changes belong in a separate commit.

================
Comment at: SourceCoverageViewText.cpp:165
@@ -165,1 +164,3 @@
+                                                 CoverageSegmentArray Segments,
+                                                 unsigned ViewDepth) {
   renderLinePrefix(OS, ViewDepth);
----------------
Since this change doesn't affect your patch's functionality, let's do it in a follow-up commit.


https://reviews.llvm.org/D23486