[PATCH] D23557: [RISCV 1/10] Recognise riscv32 and riscv64 in triple parsing code

Ed Maste via llvm-commits llvm-commits at lists.llvm.org
Tue Aug 16 14:34:09 PDT 2016


emaste added inline comments.

================
Comment at: unittests/ADT/TripleTest.cpp:257-261
@@ +256,7 @@
+
+  T = Triple("riscv64-unknown-linux");
+  EXPECT_EQ(Triple::riscv64, T.getArch());
+  EXPECT_EQ(Triple::UnknownVendor, T.getVendor());
+  EXPECT_EQ(Triple::Linux, T.getOS());
+  EXPECT_EQ(Triple::UnknownEnvironment, T.getEnvironment());
+
----------------
Worth adding a "riscv64-unknown-freebsd" as well?


https://reviews.llvm.org/D23557





More information about the llvm-commits mailing list