[PATCH] D23410: [SLP] Initialize VectorizedValue when gathering

Michael Kuperstein via llvm-commits llvm-commits at lists.llvm.org
Tue Aug 16 14:07:18 PDT 2016


mkuper added a comment.

I'm still slightly concerned. One of the reasons we'd bail out of buildTree_rec is if we hit one of the thresholds - whose only reason to exist in the first place is to provide an upper bound on compile time. So if bailing out of buildTree_rec because we exceeded a threshold causes us to take a compile-time hit, that's probably not good.
But I may just be paranoid - we'll take a hit only if we both exceeded the thresholds *and* the bundle is not in-order, and that may be extremely rare.

Other than that, LGTM.


https://reviews.llvm.org/D23410





More information about the llvm-commits mailing list