[PATCH] D23328: AMDGPU: Update AMDGPURuntimeMetadata.h for enums of address space qualifiers

[Matt Arsenault via llvm-commits]

arsenm added inline comments.

================
Comment at: lib/Target/AMDGPU/AMDGPURuntimeMetadata.h:136-141
@@ -135,1 +135,8 @@
+
+    enum AddressSpaceQualifer : uint8_t {
+      Private    = 0,
+      Global     = 1,
+      Constant   = 2,
+      Local      = 3,
+    };
   } // namespace KernelArg
----------------
yaxunl wrote:
> arsenm wrote:
> > yaxunl wrote:
> > > arsenm wrote:
> > > > Should probably have the values for flat and region
> > > This is for OpenCL kernel argument reflection. flat and region address spaces do not show up in kernel arguments.
> > Region would if that extension were ever finished. There's no real reason we can't support flat either. The values should be there to make sure they are reserved / keep the same values as the address space enum
> What is the value for region and flat address space? Thanks.
generic is 4 and region is 5


https://reviews.llvm.org/D23328