[PATCH] D23542: [LTO] Introduce an Output class to wrap the output stream creation (NFC)
Mehdi AMINI via llvm-commits
llvm-commits at lists.llvm.org
Tue Aug 16 12:56:18 PDT 2016
mehdi_amini added inline comments.
================
Comment at: tools/gold/gold-plugin.cpp:657
@@ -658,3 +656,3 @@
std::error_code EC =
sys::fs::createTemporaryFile("lto-llvm", "o", FD, NewFilename);
if (EC)
----------------
tejohnson wrote:
> FD was not declared, which exposes an issue - the interface needs to handle this being a temp file that we create here.
Does it? Can't we just not create the file open?
https://reviews.llvm.org/D23542
More information about the llvm-commits
mailing list