[PATCH] D23415: [Inliner] Report when inlining fails because callee's def is unavailable

[David Li via llvm-commits]

davidxl added inline comments.

================
Comment at: include/llvm/Analysis/OptimizationDiagnosticInfo.h:146
@@ +145,3 @@
+  /// The debug location and the code region is derived from \p Inst.
+  void emitOptimizationRemarkMissedAndAnalysis(
+      const char *PassName, Instruction *Inst, const Twine &MsgForMissedRemark,
----------------
Is there a need for this wrapper?

================
Comment at: lib/Transforms/IPO/Inliner.cpp:455
@@ +454,3 @@
+          if (Callee->isDeclaration()) {
+            ORE.emitOptimizationRemarkMissedAndAnalysis(
+                DEBUG_TYPE, &I,
----------------
This message can be useful for thinLTO compilation, but for O2, I fear it can be quite noisy.  Perhaps using another option to make it default?


https://reviews.llvm.org/D23415