[PATCH] D23542: [LTO] Introduce an Output class to wrap the output stream creation (NFC)

Teresa Johnson via llvm-commits llvm-commits at lists.llvm.org
Tue Aug 16 11:06:07 PDT 2016


tejohnson added a comment.

Looks ok, let me download the patch and try with gold though. Will get back later today.


================
Comment at: include/llvm/LTO/LTO.h:235
@@ +234,3 @@
+/// client of the LTO API.
+class Output {
+public:
----------------
Maybe "NativeObjectOutput" or something like that to make it clear - one thing I would like to change eventually is the fact that this callback is passed to the WriteIndexesThinBackend, which doesn't write a native object file.


https://reviews.llvm.org/D23542





More information about the llvm-commits mailing list