[llvm] r278463 - [BranchFolding] Restrict tail merging loop blocks after MBP

[Hans Wennborg via llvm-commits]

I've merged that to 3.9 in r278827:
http://llvm.org/viewvc/llvm-project?rev=278827&view=rev

I had to change the test as it wasn't passing on the branch,
presumably due to different machine block placement. Can you please
double check that I got it right, and would it be possible to make the
test less brittle? For example, adding explicit label names might be a
good idea.

On Mon, Aug 15, 2016 at 7:22 AM, Haicheng Wu <haicheng at codeaurora.org> wrote:
> I recommitted in r278575.
>
> Thanks,
>
> Haicheng
>
> Haicheng Wu
> Employee of Qualcomm Datacenter Technologies, Inc.
> Qualcomm Datacenter Technologies, Inc. as an affiliate of Qualcomm Technologies, Inc.  Qualcomm Technologies, Inc. is a member of the Code Aurora Forum, a Linux Foundation Collaborative Project.
>
> -----Original Message-----
> From: hwennborg at google.com [mailto:hwennborg at google.com] On Behalf Of Hans Wennborg
> Sent: Friday, August 12, 2016 2:04 PM
> To: Haicheng Wu <haicheng at codeaurora.org>
> Cc: llvm-commits <llvm-commits at lists.llvm.org>
> Subject: Re: [llvm] r278463 - [BranchFolding] Restrict tail merging loop blocks after MBP
>
> On Thu, Aug 11, 2016 at 8:30 PM, Haicheng Wu via llvm-commits <llvm-commits at lists.llvm.org> wrote:
>> Author: haicheng
>> Date: Thu Aug 11 22:30:23 2016
>> New Revision: 278463
>>
>> URL: http://llvm.org/viewvc/llvm-project?rev=278463&view=rev
>> Log:
>> [BranchFolding] Restrict tail merging loop blocks after MBP
>>
>> To fix PR28014, this patch restricts tail merging to blocks that
>> belong to the same loop after MBP.
>
> I believe you mean PR28104?
>
> It seems this got reverted in r278484. Do you think it will be easy to fix? It would be great if we could fix this for 3.9.
>
> Thanks,
> Hans
>