[PATCH] D23486: [llvm-cov] Add coverage summary information to the HTML index page.

[Vedant Kumar via llvm-commits]

vsk added a comment.

@rdp I noticed that you held off on adding a test with your last update. Let me know if you'd like any help with that -- I can take a shot at it if needed.


================
Comment at: CodeCoverage.cpp:655
@@ -654,3 +654,3 @@
   if (ViewOpts.hasOutputDirectory()) {
-    if (Error E = Printer->createIndexFile(SourceFiles)) {
+    if (Error E = Printer->createIndexFile(SourceFiles, *Coverage)) {
       error("Could not create index file!", toString(std::move(E)));
----------------
MaggieYi wrote:
> You don’t need to pass the ‘SourceFiles’ as a parameter anymore since you can get them by calling Coverage->getUniqueSourceFiles().
Actually, I think we still need it here to ensure addCollectedPath() + -filename-equivalence continues working as expected.


https://reviews.llvm.org/D23486