[PATCH] D23502: [ELF] Linkerscript: discard .interp section if we have custom PHDRS layout and PT_INTERP is not listed.

[Eugene Leviant via llvm-commits]

evgeny777 added inline comments.

================
Comment at: ELF/LinkerScript.cpp:489
@@ -488,1 +488,3 @@
 
+template <class ELFT> bool LinkerScript<ELFT>::discardInterpSection() {
+  // Discard .interp section in case we have PHDRS specification
----------------
ruiu wrote:
> `Discard` sounds like this function discards (or remove) an existing section from an output section list, so it's a bit confusing. I'd name `needsInterpSection`.
I can't decide in whether we **need** .interp section or not. I can only tell if we do not need it. So I renamed to ignoreInterpSection


Repository:
  rL LLVM

https://reviews.llvm.org/D23502