[PATCH] D23525: [ThinLTO] Fix temp file dumping, enable via llvm-lto and test it

Teresa Johnson via llvm-commits llvm-commits at lists.llvm.org
Mon Aug 15 16:32:43 PDT 2016


tejohnson added inline comments.

================
Comment at: lib/LTO/ThinLTOCodeGenerator.cpp:82
@@ -82,2 +81,3 @@
   std::error_code EC;
-  raw_fd_ostream OS(SaveTempPath.str(), EC, sys::fs::F_None);
+  raw_fd_ostream OS((TempDir + llvm::utostr(count) + Suffix).str(), EC,
+                    sys::fs::F_None);
----------------
mehdi_amini wrote:
> To avoid the code duplication, can we keep the SaveTempPath but declared as follows?
> 
> ```
> std::string SaveTempPath = (TempDir + llvm::utostr(count) + Suffix).str();
> ```
Yep, done. Will commit version with that change.


https://reviews.llvm.org/D23525





More information about the llvm-commits mailing list