[PATCH] D21808: [WebAssembly] Handle debug information and virtual registers without crashing

[Derek Schuff via llvm-commits]

dschuff added inline comments.

================
Comment at: test/DebugInfo/WebAssembly/live-intervals.ll:1
@@ +1,2 @@
+; RUN: llc < %s -verify-machineinstrs -mtriple=wasm32-unknown-unknown | FileCheck %s
+; CHECK: #DEBUG_VALUE: decode:i <- [%vreg
----------------
Does this work with fast-isel too?

================
Comment at: test/DebugInfo/WebAssembly/live-intervals.ll:1
@@ +1,2 @@
+; RUN: llc < %s -verify-machineinstrs -mtriple=wasm32-unknown-unknown | FileCheck %s
+; CHECK: #DEBUG_VALUE: decode:i <- [%vreg
----------------
dschuff wrote:
> Does this work with fast-isel too?
I think the name of the test should refer to debug values somehow since that's why it exists.

================
Comment at: test/DebugInfo/WebAssembly/wasm.ll:1
@@ +1,2 @@
+; RUN: llc < %s -verify-machineinstrs -mtriple=wasm32-unknown-unknown | FileCheck %s
+; CHECK: #DEBUG_VALUE: main:argv <- [%vreg
----------------
Likewise with fast-isel and the name of the test could be more descriptive.


https://reviews.llvm.org/D21808