[PATCH] D23445: [x86] Refactor a PowerPC specific ctlz/srl transformation (NFC).

Hal Finkel via llvm-commits llvm-commits at lists.llvm.org
Mon Aug 15 10:59:02 PDT 2016


hfinkel added inline comments.

================
Comment at: include/llvm/Target/TargetLowering.h:3063
@@ +3062,3 @@
+  // fact that this can be implemented as a ctlz/srl pair, so that the dag
+  // combiner can fold the new nodes.
+  SDValue LowerCmpEqZeroToCtlzSrl(SDValue Op, SelectionDAG &DAG) const;
----------------
I think it would be clearer if you include in the comment the form of the transform; something like:
  // seteq(x, 0) -> truncate(srl(ctlz(zext(x)), log2(#bits)))



https://reviews.llvm.org/D23445





More information about the llvm-commits mailing list