[PATCH] D23514: [ELF] - Do not change binding for hidden symbols when creating relocatable output.

[Rui Ueyama via llvm-commits]

ruiu added inline comments.

================
Comment at: ELF/OutputSections.cpp:1319
@@ -1318,2 +1318,3 @@
   Symbol *S = Body->symbol();
   uint8_t Visibility = S->Visibility;
+  if (!Config->Relocatable)
----------------
I'm not sure if this would fix the problem entirely. My gut is that we want to keep the original symbol type if -r is specified. If that's the case, we want to add

  if (Config->Relocatable)
    return S->Binding;

here. But I don't know if that's correct.


https://reviews.llvm.org/D23514