[PATCH] D23376: [compiler-rt] Allow c++ abi to be explictly disabled in cmake configuration
Reid Kleckner via llvm-commits
llvm-commits at lists.llvm.org
Mon Aug 15 10:31:34 PDT 2016
rnk added inline comments.
================
Comment at: CMakeLists.txt:217
@@ -215,2 +216,3 @@
+ endif()
endif()
pythonize_bool(SANITIZER_CAN_USE_CXXABI)
----------------
I think you should hoist this up to the end of the options and make this an option(). Use the existing logic to provide the default value.
https://reviews.llvm.org/D23376
More information about the llvm-commits
mailing list