[compiler-rt] r278454 - [CMake] If the compiler supports _Atomic include atomic.c in builtins libraries

Hans Wennborg via llvm-commits llvm-commits at lists.llvm.org
Mon Aug 15 09:49:11 PDT 2016


On Fri, Aug 12, 2016 at 5:56 PM, Saleem Abdulrasool
<compnerd at compnerd.org> wrote:
> On Thu, Aug 11, 2016 at 6:29 PM, Chris Bieneman via llvm-commits
> <llvm-commits at lists.llvm.org> wrote:
>>
>> Author: cbieneman
>> Date: Thu Aug 11 20:29:26 2016
>> New Revision: 278454
>>
>> URL: http://llvm.org/viewvc/llvm-project?rev=278454&view=rev
>> Log:
>> [CMake] If the compiler supports _Atomic include atomic.c in builtins
>> libraries
>>
>> This fixes a long-standing TODO by implementing a compiler check for
>> supporting the _Atomic keyword. If the _Atomic keyword is supported by the
>> compiler we should include it in the builtin library sources.
>>
>> Modified:
>>     compiler-rt/trunk/cmake/Modules/BuiltinTests.cmake
>>     compiler-rt/trunk/cmake/builtin-config-ix.cmake
>>     compiler-rt/trunk/lib/builtins/CMakeLists.txt
>
>
> I think this belongs in 3.9 as well as otherwise you end up with the
> builtins missing the atomics which are needed for sizes which cannot be
> lowered directly to instructions.

SGTM. Merged in r278679.

Cheers,
Hans


More information about the llvm-commits mailing list